Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/spanprocessor] Allow changing of span.kind #12324

Closed

Conversation

boostchicken
Copy link
Member

Signed-off-by: John D [email protected]

Description: Add the ability to change Span.Kind

Link to tracking Issue: #6883

Testing: New unit tests added

Documentation: README.md updated

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 27, 2022
@boostchicken
Copy link
Member Author

@ @Aneurysm9 @pmm-sumo can I get somen eyes on this?

@TylerHelmuth
Copy link
Member

I believe this PR duplicates functionality that already exists in the transformprocessor. I'm not saying thats unacceptable necessarily, but this is possible to do in the collector today.

@TylerHelmuth
Copy link
Member

@open-telemetry/collector-contrib-approvers how do we want to handle duplicate functionality? @boostchicken would users always need a unique instance of the spanprocessor thats dedicated to changing span.kind or could it be added to an existing config of the processor? Is it conditional, or would every incoming span have its kind updated?

@boostchicken
Copy link
Member Author

boostchicken commented Aug 5, 2022

@open-telemetry/collector-contrib-approvers how do we want to handle duplicate functionality? @boostchicken would users always need a unique instance of the spanprocessor thats dedicated to changing span.kind or could it be added to an existing config of the processor? Is it conditional, or would every incoming span have its kind updated?

Please see the issue. The SpanProcessor is the problem this. I am not aware of this being a duplicate functionality.

Ahhh I found it. I would suggest this belongs here. This is existing, you could add it to any span processor.

@github-actions github-actions bot removed the Stale label Aug 6, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 26, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants