[exporter/awscloudwatchlogsexporter] Enable logGroup and logStream templating #12179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to multiple pushers Signed-off-by: John Dorman <[email protected]>
boostchicken
changed the title
Signed-off-by: John Dorman <[email protected]>
Signed-off-by: John Dorman <[email protected]>
Signed-off-by: John Dorman <[email protected]>
Signed-off-by: John Dorman <[email protected]>
Aneurysm9
reviewed
Jul 8, 2022
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
# Conflicts: # internal/aws/cwlogs/go.mod
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John Dorman <[email protected]>
Aneurysm9
reviewed
Jul 12, 2022
Signed-off-by: John D <[email protected]>
|
Thank you so much for your work on this @boostchicken ! |
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
Signed-off-by: John D <[email protected]>
# Conflicts: # exporter/awsemfexporter/util.go # internal/aws/cwlogs/go.mod
|
@Aneurysm9 this is not state and is ready for merge> |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Any reason why this was nevver merged? |
|
Unfortunately, it looks like it was missed in the backlog of PRs. If you'd still like this feature in, please reopen and rebase with main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows templating in logStream and logGroup, enables this to consume logs from multiple nodes.
Signed-off-by: John Dorman [email protected]
Description: Cloudwatch Logs exporter now supports multiple pushers, this way it can support input from multiple nodes
Link to tracking Issue: #10887
Testing: Existing Unit Tests