2/3 Add Windows Performance Counters Receiver skeleton implementation #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
changed the title
james-bebbington
force-pushed
the
windowsperfcounters-receiver-2
branch
3 times, most recently
from
e48ca5b
to
66d0137
Compare
james-bebbington
changed the title
asuresh4
reviewed
Oct 9, 2020
Will come back to this PR once the Scraper library is finalized in core |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
james-bebbington
force-pushed
the
windowsperfcounters-receiver-2
branch
3 times, most recently
from
944df77
to
71ffa05
Compare
|
This is ready for review now |
james-bebbington
force-pushed
the
windowsperfcounters-receiver-2
branch
4 times, most recently
from
f9b6b1b
to
d6a31a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
===========================================
+ Coverage 70.87% 88.77% +17.89%
===========================================
Files 29 344 +315
Lines 1298 16682 +15384
===========================================
+ Hits 920 14809 +13889
- Misses 321 1406 +1085
- Partials 57 467 +410
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asuresh4
reviewed
Oct 29, 2020
receiver/windowsperfcountersreceiver/windowsperfcounters_scraper.go
Outdated
Show resolved
Hide resolved
james-bebbington
force-pushed
the
windowsperfcounters-receiver-2
branch
from
d6a31a7
to
fba4359
Compare
asuresh4
approved these changes
Oct 29, 2020
tigrannajaryan
approved these changes
Oct 30, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: #1088
Description: Adds skeleton for Windows Performance Counters Receiver with very basic initial functionality that can read simple counters that do not include any instance into a Gauge metric - see the added README.md for more details.
Note the scaffolding code makes use of the new
receiverhelper&scraperhelperfunctions added in the Core PRs referenced below.Depends on: #1175, open-telemetry/opentelemetry-collector#1886, open-telemetry/opentelemetry-collector#1890