Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redactionprocessor: respect allow_all_keys configuration #11542

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 24, 2022

Description: Skip redacting keys if allow_all_keys is configured to true

fixes #11450

Testing: Added a test to ensure keys are not redacted and a test to ensure values are still masked if applicable

@dyladan dyladan requested a review from a team June 24, 2022 18:05
@dyladan dyladan requested review from dmitryax and mx-psi as code owners June 24, 2022 18:05
@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Jun 24, 2022
@dmitryax dmitryax merged commit 53ae9be into open-telemetry:main Jun 24, 2022
@dyladan dyladan deleted the allow-all-keys branch June 26, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/redaction] The Redaction Processor does not honor the allow_all_keys configuration
3 participants