Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add status header for SAP HANA receiver #11104

Merged

Conversation

Frapschen
Copy link
Contributor

Description:
Add status header for SAP HANA receiver

@Frapschen Frapschen requested a review from a team June 17, 2022 09:38
@Frapschen Frapschen requested a review from pmm-sumo as a code owner June 17, 2022 09:38
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 17, 2022
@Frapschen
Copy link
Contributor Author

/cc @pmm-sumo @dehaansa as code owners to verify new status header

Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this is in development since it is not part of contrib distribution (yet) though I believe it could be added there @dehaansa ?

@dehaansa
Copy link
Contributor

Technically, this is in development since it is not part of contrib distribution (yet) though I believe it could be added there @dehaansa ?

What do you mean by "not part of the contrib distribution"? It's added to the contrib collector in components.go, my understanding was that was the main portion of adding to the contrib distribution

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Frapschen Frapschen requested review from codeboten and pmm-sumo June 27, 2022 13:18
@Frapschen Frapschen requested a review from pmm-sumo June 29, 2022 03:36
@mx-psi mx-psi merged commit fbaccad into open-telemetry:main Jul 5, 2022
@Frapschen Frapschen deleted the Add_status_header_for_saphana_rc branch July 7, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants