use go workspace #10904
Closed
use go workspace #10904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@codeboten are we going to have this 👯 ? |
|
@bogdandrutu yes I'll tackle this as soon as I can get #12918 merged |
codeboten
force-pushed
the
codeboten/workspaces
branch
from
ba72fd0 to
4ef2367
Compare
codeboten
requested review from
djaglowski,
dashpole,
jmacd,
dmitryax and
Aneurysm9
as code owners
codeboten
requested review from
jpkrohling,
TylerHelmuth,
bogdandrutu,
mx-psi,
jsuereth,
punya,
arminru and
alolita
as code owners
codeboten
force-pushed
the
codeboten/workspaces
branch
3 times, most recently
from
bcd69ce to
7bd7ce8
Compare
codeboten
force-pushed
the
codeboten/workspaces
branch
2 times, most recently
from
831b166 to
8d86626
Compare
jmacd
approved these changes
Aug 5, 2022
codeboten
force-pushed
the
codeboten/workspaces
branch
2 times, most recently
from
6a84fc9 to
9d4cbab
Compare
jpkrohling
reviewed
Aug 8, 2022
go.work
Outdated
| // references to modules that are in this repository with their relative paths | ||
| // so that we always build with current (latest) version of the source code. | ||
|
|
||
| replace ( |
There was a problem hiding this comment.
I assume this would cause the release process to change a bit. If that's the case, can we have an update to it as part of this PR?
mx-psi
reviewed
Aug 8, 2022
This was referenced Aug 8, 2022
codeboten
force-pushed
the
codeboten/workspaces
branch
from
9d4cbab to
d6be8c1
Compare
codeboten
force-pushed
the
codeboten/workspaces
branch
from
d6be8c1 to
9e881eb
Compare
added 5 commits
September 15, 2022 15:29
This change removes the need for replace statements in all modules within this repository.
codeboten
force-pushed
the
codeboten/workspaces
branch
from
efceb37 to
fb991d1
Compare
|
Closing this for now, there's no clear path to move forward with workspaces in this repo as it adds unnecessary complexity to the release process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the need for
replacestatements in all modules within this repository. Some additional changes needed to make this work:update example docker base imageupdate compliance tests to avoid issue w/ go workspace