Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add status header for honeycomb exporter #10318

Merged
merged 8 commits into from
Jun 14, 2022
Merged

[docs] Add status header for honeycomb exporter #10318

merged 8 commits into from
Jun 14, 2022

Conversation

Frapschen
Copy link
Contributor

Description:
Add status header for honeycomb exporter.

@Frapschen Frapschen requested review from a team and bogdandrutu May 25, 2022 08:14
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 25, 2022
@dashpole
Copy link
Contributor

Should this be deprecated instead of beta given the note at the top of the exporter?

codeboten
codeboten reviewed May 25, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging codeowners @paulosman @lizthegrey @MikeGoldsmith, please take a look at @dashpole's question

@codeboten codeboten mentioned this pull request May 25, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 9, 2022
@Frapschen
Copy link
Contributor Author

hi, @paulosman @lizthegrey @MikeGoldsmith can you have time to review this PR?

@Frapschen
Copy link
Contributor Author

hi @paulosman @lizthegrey @MikeGoldsmith can you review this PR?

@github-actions github-actions bot removed the Stale label Jun 10, 2022
@MikeGoldsmith
Copy link
Member

Yes, sorry - I was tracking this and it got lost on my list.

I'll review today 👍🏻

@MikeGoldsmith
Copy link
Member

Yes, I agree with @dashpole. We would prefer this to be marked as deprecated.

Honeycomb supports directly receiving OTLP over gRPC & HTTP/proto and that's our preferred ingest method.

@Frapschen
Copy link
Contributor Author

@MikeGoldsmith mark honeycomb exporter as deprecated.

MikeGoldsmith
MikeGoldsmith approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Frapschen. Just left one minor update.

exporter/honeycombexporter/go.mod Outdated Show resolved Hide resolved
@Frapschen Frapschen requested a review from MikeGoldsmith June 11, 2022 13:57
codeboten
codeboten reviewed Jun 13, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the following to update go.sum:

make -C exporter/honeycombexporter tidy

@Frapschen Frapschen requested a review from codeboten June 13, 2022 23:35
@codeboten codeboten merged commit 86b47f8 into open-telemetry:main Jun 14, 2022
@Frapschen Frapschen deleted the Add_status_header_for_honeycomb branch July 7, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@codeboten codeboten Awaiting requested review from codeboten

Assignees

@dashpole dashpole

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Frapschen @dashpole @MikeGoldsmith @codeboten @mx-psi