Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add header for file exporter. #10175

Merged
merged 4 commits into from
May 31, 2022
Merged

[docs] add header for file exporter. #10175

merged 4 commits into from
May 31, 2022

Conversation

Frapschen
Copy link
Contributor

@Frapschen Frapschen commented May 20, 2022 •
edited by codeboten
Loading

Description:
I add a header for file exporter, pls review :)

Fixes #10265

@Frapschen Frapschen requested a review from a team May 20, 2022 00:10
@Frapschen Frapschen requested a review from pmm-sumo as a code owner May 20, 2022 00:10
@Frapschen Frapschen changed the title add header for file exporter. [docs] add header for file exporter. May 20, 2022
@Frapschen
Copy link
Contributor Author

hi, pls review :)

TylerHelmuth
TylerHelmuth approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @pmm-sumo as code owner

pmm-sumo
pmm-sumo suggested changes May 30, 2022
View reviewed changes
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should consider it an alpha exporter.

This is hinted by the documentation:

Please note that there is no guarantee that exact field names will remain stable. This intended for primarily for debugging Collector without setting up backends.

@Frapschen @pmm-sumo
Apply suggestions from code review
a9d2da7 
Co-authored-by: Przemek Maciolek <[email protected]>
@Frapschen
Copy link
Contributor Author

@pmm-sumo done.

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 31, 2022
@Frapschen Frapschen requested a review from pmm-sumo May 31, 2022 08:56
codeboten
codeboten reviewed May 31, 2022
View reviewed changes
exporter/fileexporter/README.md Outdated Show resolved Hide resolved
exporter/fileexporter/README.md Show resolved Hide resolved
@codeboten codeboten merged commit 5878dbf into open-telemetry:main May 31, 2022
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
@Frapschen @pmm-sumo @kentquirk
[docs] add header for file exporter. (open-telemetry#10175)
a83a88c 
* add header for file exporter.

* Update exporter/fileexporter/README.md

* Apply suggestions from code review

Co-authored-by: Przemek Maciolek <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
@Frapschen Frapschen deleted the add_header_exporter_file branch July 7, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@mx-psi mx-psi mx-psi approved these changes

Assignees

@mx-psi mx-psi

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add status header for file
5 participants
@Frapschen @codeboten @mx-psi @TylerHelmuth @pmm-sumo