Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/filelog] docs: update include_file_name and similar parameters' descriptions #10154

Merged
merged 1 commit into from
May 19, 2022

Conversation

andrzej-stencel
Copy link
Member

@andrzej-stencel andrzej-stencel commented May 19, 2022

Description:

Fixing documentation for the following configuration parameters:

  • include_file_name
  • include_file_name_resolved
  • include_file_path
  • include_file_path_resolved

The descriptions of those parameters have been long outdated (or missing).
Copied the latest descriptions from https://github.com/open-telemetry/opentelemetry-log-collection/blob/v0.29.1/docs/operators/file_input.md.

Note: It's easier to see the changes in GitHub UI when you select the Hide whitespace checkbox in diff settings.

@andrzej-stencel andrzej-stencel requested a review from a team May 19, 2022 10:52
@andrzej-stencel
Copy link
Member Author

I think this change requires the Skip Changelog label, but I'm not allowed to add it.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 19, 2022
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @astencel-sumo

@djaglowski djaglowski merged commit eb594ba into open-telemetry:main May 19, 2022
@andrzej-stencel andrzej-stencel deleted the update-filelog-docs branch May 19, 2022 14:00
jamesmoessis pushed a commit to jamesmoessis/opentelemetry-collector-contrib that referenced this pull request May 20, 2022
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants