Run unit tests on Windows and fix them #10027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
enable-windows-make
branch
5 times, most recently
from
0bb1a58 to
b0bf981
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
enable-windows-make
branch
6 times, most recently
from
0f40856 to
1a40ade
Compare
dmitryax
commented
May 16, 2022
| @@ -279,49 +268,3 @@ func Test_Scraping_Wildcard(t *testing.T) { | |||
|
|
|||
| require.GreaterOrEqual(t, len(counterVals), 3) | |||
| } | |||
|
|
|||
| // Test_Closing ensures that watchers close appropriately | |||
| func Test_Closing(t *testing.T) { | |||
There was a problem hiding this comment.
Removed instead of fixing. This test doesn't test any production code, only mockPerfCounter functionality.
dmitryax
force-pushed
the
enable-windows-make
branch
from
1a40ade to
3bb0d76
Compare
dmitryax
commented
May 16, 2022
|
|
||
| // Test_Scraping ensures that watchers watch appropriately using mocked perfcounters to | ||
| // pass valus through | ||
| func Test_Scraping(t *testing.T) { |
There was a problem hiding this comment.
Removed instead of fixing. This test doesn't test any production code, only mockPerfCounter functionality.
dmitryax
force-pushed
the
enable-windows-make
branch
13 times, most recently
from
f9daa4a to
fff6fb5
Compare
dmitryax
force-pushed
the
enable-windows-make
branch
13 times, most recently
from
9c5e713 to
2cc6acc
Compare
dmitryax
force-pushed
the
enable-windows-make
branch
from
2cc6acc to
54d2ee6
Compare
dmitryax
requested review from
dashpole,
jmacd,
djaglowski and
Aneurysm9
as code owners
djaglowski
approved these changes
May 19, 2022
|
@open-telemetry/collector-contrib-approvers PTAL |
pmm-sumo
approved these changes
May 19, 2022
jamesmoessis
pushed a commit
to jamesmoessis/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2022
Enable all unit tests on Windows and fix them
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
Enable all unit tests on Windows and fix them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been running Windows tests only for couple receivers. This PR enables Windows unit tests for all modules and attempts to fix those that are failing.
Most of the failing tests are fixed in this PR. The following are still to be resolved: