Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Reenable all checks except some linters #10013

Merged

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented May 13, 2022

Resolves #9951
Resolves #9952
Resolves #9953 (but opened #10012 as a followup)

Altogether, this removes all special handling of pkg/stanza, except for that which is defined in pkg/stanza/.golangci.yml.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 13, 2022
@djaglowski djaglowski marked this pull request as ready for review May 13, 2022 21:25
@djaglowski djaglowski requested review from a team and Aneurysm9 May 13, 2022 21:25
pkg/stanza/.golangci.yml Show resolved Hide resolved
pkg/stanza/testutil/mocks.go Outdated Show resolved Hide resolved
@djaglowski djaglowski force-pushed the pkg-stanza-include-some-checks branch from d0ac916 to 344b6d1 Compare May 16, 2022 14:25
@djaglowski djaglowski requested a review from bogdandrutu May 19, 2022 13:46
@djaglowski djaglowski force-pushed the pkg-stanza-include-some-checks branch 2 times, most recently from 8dfd6ce to f127cab Compare May 19, 2022 20:22
@djaglowski djaglowski merged commit ad6b5ca into open-telemetry:main May 23, 2022
@djaglowski djaglowski deleted the pkg-stanza-include-some-checks branch May 23, 2022 18:28
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
…10013)

* [pkg/stanza] Reenable all checks except some linters

* Fix pkg/stanza/go.mod

* Remove mockery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
5 participants