Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheusreceiver] Support exemplars from Prometheus #8353

Closed
dashpole opened this issue Mar 9, 2022 · 4 comments
Closed

[prometheusreceiver] Support exemplars from Prometheus #8353

dashpole opened this issue Mar 9, 2022 · 4 comments
Labels
comp:prometheus Prometheus related issues enhancement New feature or request spec:metrics Stale

Comments

@dashpole
Copy link
Contributor

dashpole commented Mar 9, 2022

Is your feature request related to a problem? Please describe.
Currently, the prometheus receiver drops prometheus exemplars:

func (t *transactionPdata) AppendExemplar(ref storage.SeriesRef, l labels.Labels, e exemplar.Exemplar) (storage.SeriesRef, error) {
return 0, nil
}

Describe the solution you'd like
As described in the prometheus conversion specification, exemplars on prometheus metrics should be converted to exemplars in OpenTelemetry.

@dashpole
Copy link
Contributor Author

dashpole commented Sep 2, 2022

Fixed by #12987

@dashpole dashpole closed this as completed Sep 2, 2022
@bboreham
Copy link
Contributor

bboreham commented Sep 9, 2022

This should be re-opened, as #12987 was reverted in #14000.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 10, 2022
@jeromeinsf
Copy link

What's left to do after #14132 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:prometheus Prometheus related issues enhancement New feature or request spec:metrics Stale
Projects
None yet
Development

No branches or pull requests

3 participants