Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing feature flags to Prometheus receiver #1173

Closed
dnutels opened this issue Apr 26, 2022 · 5 comments
Closed

Allow passing feature flags to Prometheus receiver #1173

dnutels opened this issue Apr 26, 2022 · 5 comments
Labels

Comments

@dnutels
Copy link

dnutels commented Apr 26, 2022

Is your feature request related to a problem? Please describe.

Ability to enable exemplars, currently an experimental feature, for the Prometheus receiver. For "vanilla" Prometheus
it is done via --enable-feature=exemplar-storage.

Describe the solution you'd like

Looking for a way to pass Prometheus flags to the ADOT collector.

Reason — exemplars are behind a feature flag, that for “regular” Prometheus would be passed (using docker compose as an example) like this:

services:
  ...
  prometheus:
    image: prom/prometheus:latest
    command: 
      - '--config.file=/etc/prometheus/prometheus.yml'
      - '--enable-feature=exemplar-storage'
    volumes:
      - ${PWD}/infra/prometheus/config.yml:/etc/prometheus/prometheus.yml
    ports:
      - '9090:9090'

Then prometheus would scrape OpenMetrics format with exemplars… equivalent to:

curl example.com:3000/metrics -H "Accept: application/openmetrics-text"

Describe alternatives you've considered

OTEL collector or N/A

Additional context

N/A

@Aneurysm9
Copy link
Member

Support for exemplars in the upstream prometheus receiver is tracked with this issue. It should not be necessary to support the exemplar-storage feature flag as that controls whether exemplars are stored in the TSDB, which is not is use by the collector.

@dnutels
Copy link
Author

dnutels commented May 3, 2022

Correct me here, but without this flag, these are currently not collected or shipped from the receiver forward.

My thinking was -- since, at this point, the receiver is a minimal implementation, perhaps enabling experimental flag in the upstream/adot would be a quicker/simpler stop-gap solution, which Prometheus already provides.

@Aneurysm9 Aneurysm9 removed their assignment Jun 29, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Aug 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2022
@ckt114
Copy link

ckt114 commented Jun 16, 2023

Are there any plan to allow --enable-feature to be passed into prometheus receiver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants