Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/cgroupruntime] Add cgroup integration tests #36545

Open
rogercoll opened this issue Nov 26, 2024 · 2 comments · May be fixed by #36617
Open

[extension/cgroupruntime] Add cgroup integration tests #36545

rogercoll opened this issue Nov 26, 2024 · 2 comments · May be fixed by #36617

Comments

@rogercoll
Copy link
Contributor

rogercoll commented Nov 26, 2024

Component(s)

extension/cgroupruntime

Is your feature request related to a problem? Please describe.

A new extension is being created to modify in runtime the values of GOMEMLIMIT and GOMAXPROCS based on the resource limits within a cgroup: #30289

The initial implementation includes the base files and unit tests needed for using the extension. However, to be part of the contrib distribution, integration tests also need to be added: #35472 (comment)

Describe the solution you'd like

Integration tests that modify cgroup resource limits and asserts the corresponding GOMEMLIMIT and GOMAXPROCS values.

Describe alternatives you've considered

No response

Additional context

No response

@rogercoll rogercoll added enhancement New feature or request needs triage New item requiring triage labels Nov 26, 2024
@rogercoll
Copy link
Contributor Author

Component label will be available after #35472

@mx-psi mx-psi added extension/cgroupruntime priority:p1 High and removed needs triage New item requiring triage labels Nov 27, 2024
Copy link
Contributor

Pinging code owners for extension/cgroupruntime: @mx-psi @rogercoll. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants