Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/sapm] Remove dependency on opencensus #35626

Closed
atoulme opened this issue Oct 4, 2024 · 1 comment · Fixed by #35630
Closed

[receiver/sapm] Remove dependency on opencensus #35626

atoulme opened this issue Oct 4, 2024 · 1 comment · Fixed by #35630
Assignees
@atoulme
Labels
receiver/sapm

Comments

@atoulme
Copy link
Contributor

atoulme commented Oct 4, 2024

Component(s)

receiver/sapm

Describe the issue you're reporting

➜ sapmexporter git:(rm-opencensus-goleak) go mod why go.opencensus.io

go.opencensus.io

github.com/open-telemetry/opentelemetry-collector-contrib/exporter/sapmexporter
github.com/signalfx/sapm-proto/client
go.opencensus.io/stats
go.opencensus.io/stats.test
go.opencensus.io/trace
go.opencensus.io/internal
go.opencensus.io

This dependency is no longer warranted. It should be removed so we no longer import opencensus into contrib.
@atoulme atoulme added the needs triage New item requiring triage label Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme mentioned this issue Oct 4, 2024
Merged
@atoulme atoulme removed the needs triage New item requiring triage label Oct 4, 2024
@atoulme atoulme self-assigned this Oct 4, 2024
@github-actions github-actions bot mentioned this issue Oct 8, 2024
Open
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@atoulme @AkhigbeEromo
[chore] update sapm-proto to 0.16.0 (open-telemetry#35630)
4c590ca 
Fixes
open-telemetry#35626
jmichalek132 pushed a commit to jmichalek132/opentelemetry-collector-contrib that referenced this issue Oct 10, 2024
@atoulme @jmichalek132
[chore] update sapm-proto to 0.16.0 (open-telemetry#35630)
2a16ec6 
Fixes
open-telemetry#35626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atoulme atoulme

Labels
receiver/sapm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] update sapm-proto to 0.16.0 atoulme/opentelemetry-collector-contrib
1 participant
@atoulme