Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove-toolchain and gotidy targets fail on test distros #35606

Closed
mx-psi opened this issue Oct 4, 2024 · 1 comment · Fixed by #35608
Closed

remove-toolchain and gotidy targets fail on test distros #35606

mx-psi opened this issue Oct 4, 2024 · 1 comment · Fixed by #35608
Labels
priority:p1 High release-retro Issues discussed in a release retrospective

Comments

@mx-psi
Copy link
Member

mx-psi commented Oct 4, 2024 •
edited
Loading

Component(s)

cmd/otelcontribcol, cmd/oteltestbedcol

Describe the issue you're reporting

Since #34844 the targets that run in all components and expect a go.mod file are failing in cmd/oteltestbedcol. We should fix this!

Error is (for make gotidy):

Running target 'tidy' in module 'cmd/oteltestbedcol' as part of group 'all'
make --no-print-directory -C cmd/oteltestbedcol tidy
make[2]: *** No rule to make target 'tidy'.  Stop.
make[1]: *** [Makefile:191: cmd/oteltestbedcol] Error 2
make[1]: Leaving directory '/home/pablo.baeyens/Source/otel/opentelemetry-collector-contrib'
make: *** [Makefile:119: gotidy] Error 2

cc @mowies
@mx-psi mx-psi added priority:p1 High release-retro Issues discussed in a release retrospective labels Oct 4, 2024
@mx-psi mx-psi mentioned this issue Oct 4, 2024
Merged
mx-psi added a commit that referenced this issue Oct 4, 2024
@mx-psi
[chore] Prepare for v0.111.0 release (#35605)
3e034e9 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

- **[chore] Manually update builder configs**
- **[chore] multimod update stable modules**
- **[chore] multimod update beta modules**
- **make update-otel with some manual fixes**

Had to do some manual work because of #35606

---------

Signed-off-by: Pablo Baeyens <[email protected]>
@mx-psi
Copy link
Member Author

mx-psi commented Oct 4, 2024

This also failed on the automated step https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11178713977/job/31076850160

@mx-psi mx-psi mentioned this issue Oct 4, 2024
Merged
@mx-psi mx-psi closed this as completed in 7351d28 Oct 4, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@mx-psi @jriguera
[chore] Prepare for v0.111.0 release (open-telemetry#35605)
a0a6ee5 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

- **[chore] Manually update builder configs**
- **[chore] multimod update stable modules**
- **[chore] multimod update beta modules**
- **make update-otel with some manual fixes**

Had to do some manual work because of open-telemetry#35606

---------

Signed-off-by: Pablo Baeyens <[email protected]>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@mx-psi @jriguera
[chore] Remove cmd/oteltestbedcol from target list (open-telemetry#35608
0d6cd02 
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Removes `cmd/oteltestbedcol` from list since it has no Makefile

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35606
@github-actions github-actions bot mentioned this issue Oct 8, 2024
Closed
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@mx-psi @AkhigbeEromo
[chore] Prepare for v0.111.0 release (open-telemetry#35605)
4d65940 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

- **[chore] Manually update builder configs**
- **[chore] multimod update stable modules**
- **[chore] multimod update beta modules**
- **make update-otel with some manual fixes**

Had to do some manual work because of open-telemetry#35606

---------

Signed-off-by: Pablo Baeyens <[email protected]>
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@mx-psi @AkhigbeEromo
[chore] Remove cmd/oteltestbedcol from target list (open-telemetry#35608
25f2d21 
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Removes `cmd/oteltestbedcol` from list since it has no Makefile

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p1 High release-retro Issues discussed in a release retrospective
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Remove cmd/oteltestbedcol from target list mx-psi/opentelemetry-collector-contrib
1 participant
@mx-psi