Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal/buildscripts/packaging/ #34748

Closed
jpkrohling opened this issue Aug 20, 2024 · 4 comments · Fixed by #34372
Closed

Remove internal/buildscripts/packaging/ #34748

jpkrohling opened this issue Aug 20, 2024 · 4 comments · Fixed by #34372
Assignees
@jpkrohling
Labels
enhancement New feature or request

Comments

@jpkrohling
Copy link
Member

Component(s)

No response

Describe the issue you're reporting

We have internal/buildscripts/packaging/, which was used in the past when we used to generate the binaries from this repository. It's still there, and it's unclear what's the purpose.

Unless we have a clear purpose, I'd propose to remove it, because:

  1. its Dockerfile's have vulnerabilities (ie, this module requires active maintenance)
  2. it's spending CI cycles for... nothing? that's bad for the environment ;-)
@jpkrohling jpkrohling added needs triage New item requiring triage enhancement New feature or request and removed needs triage New item requiring triage labels Aug 20, 2024
@jpkrohling jpkrohling self-assigned this Aug 20, 2024
@atoulme
Copy link
Contributor

atoulme commented Aug 20, 2024

I agree that it should be removed, especially if the CI coverage it offers is best provided elsewhere already. Do we have good test coverage of the -releases artifacts as well?

@jpkrohling
Copy link
Member Author

I believe so. In fact, I think I just caught this work mid-flight: open-telemetry/opentelemetry-collector-releases#604

@mowies, do you plan on removing the buildscripts from this repository?

@mowies
Copy link
Member

mowies commented Aug 21, 2024

I did and I have a PR open already with some ongoing discussions: #34372

@jpkrohling jpkrohling linked a pull request Aug 21, 2024 that will close this issue
[chore] remove linux package builds and tests #34372
Merged
@jpkrohling
Copy link
Member Author

Thank you for the confirmation! I linked this to the PR, so that it gets closed once a resolution is found.

@github-actions github-actions bot mentioned this issue Aug 27, 2024
Closed
@mowies mowies mentioned this issue Aug 27, 2024
Closed
6 tasks
@mowies mowies mentioned this issue Sep 10, 2024
Merged
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@mowies @jriguera
[chore] remove linux package builds and tests (open-telemetry#34372)
0ae23be 
This PR removes the package tests from this repo since they were moved
to the -releases repo in
open-telemetry/opentelemetry-collector-releases#604.

Related issues:
- Original issue:
open-telemetry/opentelemetry-collector-releases#439
- Also fixes
open-telemetry#34748

Advantages of doing this:
- removal of duplicated code that has potential to diverge with linux
package building and testing happening here with custom code, but the
actual code that is used to build the released linux packages is in the
-releases repo. This should result in lower maintenance effort and
removes technical debt.

Disadvantages discussed here:
- bit of a shift-right for the linux package tests since they are now
tested in the -releases repo which could lead to situations where bugs
are found too late and e.g. the contrib repo already got a new tag which
has a bug that only comes up in the releases repo

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@mowies @AkhigbeEromo
[chore] remove linux package builds and tests (open-telemetry#34372)
85c8da2 
This PR removes the package tests from this repo since they were moved
to the -releases repo in
open-telemetry/opentelemetry-collector-releases#604.

Related issues:
- Original issue:
open-telemetry/opentelemetry-collector-releases#439
- Also fixes
open-telemetry#34748

Advantages of doing this:
- removal of duplicated code that has potential to diverge with linux
package building and testing happening here with custom code, but the
actual code that is used to build the released linux packages is in the
-releases repo. This should result in lower maintenance effort and
removes technical debt.

Disadvantages discussed here:
- bit of a shift-right for the linux package tests since they are now
tested in the -releases repo which could lead to situations where bugs
are found too late and e.g. the contrib repo already got a new tag which
has a bug that only comes up in the releases repo

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] remove linux package builds and tests dynatrace-oss-contrib/opentelemetry-collector-contrib
3 participants
@jpkrohling @atoulme @mowies