Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain and aggregate per instrumentation scope #34606

Closed
MikeGoldsmith opened this issue Aug 12, 2024 · 0 comments · Fixed by #34607
Closed

Maintain and aggregate per instrumentation scope #34606

MikeGoldsmith opened this issue Aug 12, 2024 · 0 comments · Fixed by #34607
Labels
enhancement New feature or request needs triage New item requiring triage

Comments

@MikeGoldsmith
Copy link
Member

Component(s)

processor/logdedup

Is your feature request related to a problem? Please describe.

Log records are aggregated by resource and log attributes, body and severity text. The instrumentation scope is ignored and does not form part of the exported logs payload.

Describe the solution you'd like

It should also be possible to aggregated logs per scope, using the scopes attributes, name and version. The scope should also be part of the exported logs payload.

Describe alternatives you've considered

No response

Additional context

No response

@MikeGoldsmith MikeGoldsmith added enhancement New feature or request needs triage New item requiring triage labels Aug 12, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
**Description:**

Adds a scope aggregator to separate log records by different scopes.

Also includes some refactor work:
- Extend pdatautil.hash with configurable options of values to hash,
includes ability of returning uint64
- Add consistent hash functions for resource, scope and log records that
use new hash functions
- Update aggregators to keep a copy of the original resource, scope and
log record instead of just it's attributes
  - Simplifies ConsumeLogs & Export functions
- Update newLogCounter to set lastObservedTime
- Update existing and add more tests

**Link to tracking Issue:**

- Closes open-telemetry#34606 34606

**Testing:**

Updated existing and added more unit tests to verify behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant