Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] AWS cloudwatch receiver doesn't use next token while discovering log groups #32053

Closed
gsc2001 opened this issue Apr 1, 2024 · 2 comments · Fixed by #32057
Closed

[Bug] AWS cloudwatch receiver doesn't use next token while discovering log groups #32053

gsc2001 opened this issue Apr 1, 2024 · 2 comments · Fixed by #32057
Labels
bug Something isn't working receiver/awscloudwatch

Comments

@gsc2001
Copy link

gsc2001 commented Apr 1, 2024

Component(s)

receiver/awscloudwatch

What happened?

Description

AWS cloudwatch receiver while receiving log groups calls a paged API (DescibleLogGroups) which requires multiple calls using nextToken to get full response, the code does record next Token but never uses it.

Steps to Reproduce

Use aws cloudwatch receiver

Expected Result

Discover all configured logs and collect logs

Actual Result

Keeps discovering same log groups

Collector version

v.0.93.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@gsc2001 gsc2001 added bug Something isn't working needs triage New item requiring triage labels Apr 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@schmikei schmikei mentioned this issue Apr 1, 2024
Merged
This was referenced Apr 2, 2024
Closed
Closed
@crobert-1
Copy link
Member

Removing needs triage as a code owner has opened a PR to resolve this issue.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Apr 15, 2024
djaglowski added a commit that referenced this issue May 1, 2024
@schmikei @djaglowski
[receiver/awscloudwatch]: Use next token in Log Group discovery (#32057)
088d272 
**Description:** 
Fixing a bug with the Log Group Discovery where nextToken was not
properly getting set on the request.

**Link to tracking Issue:** Resolves #32053

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working receiver/awscloudwatch
Projects
None yet
Milestone
No milestone
2 participants
@gsc2001 @crobert-1