Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/deltatocumulative] internal/streams.TestExpiry fails on Windows #31615

Closed
dmitryax opened this issue Mar 6, 2024 · 5 comments · Fixed by #31625
Closed

[processor/deltatocumulative] internal/streams.TestExpiry fails on Windows #31615

dmitryax opened this issue Mar 6, 2024 · 5 comments · Fixed by #31625
Labels

Comments

@dmitryax
Copy link
Member

dmitryax commented Mar 6, 2024

Component(s)

processor/deltatocumulative

What happened?

TestExpiry fails on Windows. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8165426471/job/22322842022

=== Failed
=== FAIL: internal/streams TestExpiry (0.78s)
    expiry_test.go:81: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/internal/streams/expiry_test.go:81
        	Error:      	Not equal: 
        	            	expected: 1m0s
        	            	actual  : 1m1s
        	Test:       	TestExpiry

=== FAIL: internal/streams TestExpiry (re-run 1) (0.82s)
    expiry_test.go:81: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/internal/streams/expiry_test.go:81
        	Error:      	Not equal: 
        	            	expected: 1m0s
        	            	actual  : 1m1s
        	Test:       	TestExpiry

DONE 2 runs, 14 tests, 2 failures in 15.740s
make[2]: *** [../../Makefile.Common:126: test] Error 1
make[1]: *** [Makefile:165: processor/deltatocumulativeprocessor] Error 2
make[1]: *** Waiting for unfinished jobs....
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Pinging code owners for processor/deltatocumulative: @sh0rez @RichieSams. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member Author

dmitryax commented Mar 6, 2024

Must be caused by #31337

@RichieSams
Copy link
Contributor

Investigating

@RichieSams
Copy link
Contributor

RichieSams commented Mar 6, 2024

@sh0rez It looks like you're using sleeps in the test code. But this isn't deterministic (and it slows down the testing). We should instead utilize setting NowFunc / similar for the expiry code. Perhaps for now we just remove the test to unblock CI, and then we can look at this again as part of the refactor discussion here: #31337 (comment)

Thoughts?

dmitryax pushed a commit that referenced this issue Mar 6, 2024
**Description:** Moves from complex preemptive expiry to a plain 1
minute timer

**Link to tracking Issue:**
#31615 (comment)

Resolves
#31615
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
**Description:** Moves from complex preemptive expiry to a plain 1
minute timer

**Link to tracking Issue:**
open-telemetry#31615 (comment)

Resolves
open-telemetry#31615
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
**Description:** Moves from complex preemptive expiry to a plain 1
minute timer

**Link to tracking Issue:**
open-telemetry#31615 (comment)

Resolves
open-telemetry#31615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants