[connector/failoverconnector] Failing unit test: TestTracesWithFailoverRecovery

[crobert-1]

Component(s)

connector/failover

Describe the issue you're reporting

CI/CD failing on unrelated PR

Failure output:

--- FAIL: TestTracesWithFailoverRecovery (0.10s)
    traces_test.go:190: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/failoverconnector/traces_test.go:190
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestTracesWithFailoverRecovery
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/connector/failoverconnector	0.325s
FAIL

[github-actions]

Pinging code owners:

• connector/failover: @akats7 @djaglowski @fatsheep9146

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Possible duplicate, but different test failing:

--- FAIL: TestLogsWithFailoverRecovery (0.10s)
    logs_test.go:186: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/failoverconnector/logs_test.go:186
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestLogsWithFailoverRecovery
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/connector/failoverconnector	0.327s
FAIL

It might be worth opening a separate issue for this, but since they look so similar we'll keep together for now.

[akats7]

Yep thats a duplicate, let me remove those tests temporarily while I mock out the time dependency, looks like its failing on certain runs

[codeboten]

This appears fixed by #31006

[crobert-1]

That fixed the traces failure, but the logs failure still needs addressed:

opentelemetry-collector-contrib/connector/failoverconnector/logs_test.go

Line 139 in e0a18f0

func TestLogsWithFailoverRecovery(t *testing.T) {

It looks like the same solution can be used there.

[akats7]

That fixed the traces failure, but the logs failure still needs addressed:

opentelemetry-collector-contrib/connector/failoverconnector/logs_test.go

Line 139 in e0a18f0

func TestLogsWithFailoverRecovery(t *testing.T) {

It looks like the same solution can be used there.

Opening a PR

[codeboten]

Thanks @akats7

[songy23]

Fixed in #31007

[crobert-1]

Fixed in #31007

The referenced PR only skips the tests, we probably want to leave this issue open until there's an opportunity to fully resolve the issue, or fix the test. Let me know if I missed something, or if that's not the right process. 👍