Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiver/postgresql: bump PostgreSQL minimal supported version to latest official supported #30923

Closed
kevinnoel-be opened this issue Jan 31, 2024 · 8 comments · Fixed by #35898
Labels

Comments

@kevinnoel-be
Copy link
Contributor

Component(s)

receiver/postgresql

Is your feature request related to a problem? Please describe.

I see that this receiver is marked as supporting PG 9.6+ in the README. Do we still want to keep this much backwards compatibility given that this is quite an old, and unsupported for 2+ years, version now (list of PG versions here). It seems that the latest supported version is PG 12 with still ~9 months of support and we should maybe align on this?
This can make improvements, using more recent features (a bit?) harder or use less maintained/out-of-date modules versions (e.g. #30831)

Describe the solution you'd like

Update the prerequisites requirements for using this receiver (+ integration tests) to the latest officially supported PostgreSQL version

Describe alternatives you've considered

No response

Additional context

No response

@kevinnoel-be kevinnoel-be added enhancement New feature or request needs triage New item requiring triage labels Jan 31, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

I'm in support of this. Let's leave the issue open for a couple weeks so others can weigh in.

@djaglowski djaglowski added discussion needed Community discussion needed and removed needs triage New item requiring triage labels Jan 31, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 1, 2024
@djaglowski djaglowski removed Stale discussion needed Community discussion needed labels Apr 1, 2024
@djaglowski
Copy link
Member

No one has argued otherwise. I suggest we initially add a deprecation warning to the changelog, then remove in a subsequent version.

@kevinnoel-be
Copy link
Contributor Author

Created following PR for adding a deprecation notice in the changelog: #32093

djaglowski pushed a commit that referenced this issue Apr 2, 2024
…32093)

**Description:**
Add deprecation notice for the minimal supported PostgreSQL version.

**Link to tracking Issue:**
#30923

**Testing:**
N/A

**Documentation:**
Changelog
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 3, 2024
@djaglowski djaglowski removed the Stale label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 5, 2024
@djaglowski djaglowski removed the Stale label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 7, 2024
djaglowski pushed a commit that referenced this issue Dec 3, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Update the prerequisites requirements for using this receiver (+
integration tests) to the latest officially supported PostgreSQL version

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes #30923

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit & integration tests

<!--Describe the documentation added.-->
#### Documentation
Updated README

<!--Please delete paragraphs that you did not use before submitting.-->
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this issue Dec 5, 2024
…35898)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Update the prerequisites requirements for using this receiver (+
integration tests) to the latest officially supported PostgreSQL version

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#30923

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit & integration tests

<!--Describe the documentation added.-->
#### Documentation
Updated README

<!--Please delete paragraphs that you did not use before submitting.-->
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this issue Dec 6, 2024
…35898)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Update the prerequisites requirements for using this receiver (+
integration tests) to the latest officially supported PostgreSQL version

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#30923

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit & integration tests

<!--Describe the documentation added.-->
#### Documentation
Updated README

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants