Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awss3] Move encodings to extensions #30554

Closed
atoulme opened this issue Jan 15, 2024 · 3 comments · Fixed by #31801
Closed

[exporter/awss3] Move encodings to extensions #30554

atoulme opened this issue Jan 15, 2024 · 3 comments · Fixed by #31801
Assignees
@atoulme
Labels
enhancement New feature or request exporter/awss3

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 15, 2024

Component(s)

exporter/awss3

Is your feature request related to a problem? Please describe.

The aws s3 exporter has encodings directly listed under it, they should each be moved to a separate extension. The exporter should then allow any encoding extension to be registered against it.

Describe the solution you'd like

as above

Describe alternatives you've considered

No response

Additional context

No response
@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Jan 15, 2024
@github-actions github-actions bot mentioned this issue Jan 16, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for exporter/awss3: @atoulme @pdelewski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 17, 2024
@crobert-1
Copy link
Member

Removing needs triage, this makes sense to me and was filed by a code owner.

@crobert-1 crobert-1 mentioned this issue Jan 23, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 18, 2024
@atoulme atoulme removed the Stale label Mar 18, 2024
@atoulme atoulme mentioned this issue Mar 18, 2024
Merged
@atoulme atoulme self-assigned this Mar 18, 2024
MovieStoreGuy pushed a commit that referenced this issue Mar 18, 2024
@atoulme
[exporter/awss3] use encoding extensions (#31801)
cbf003e 
**Description:**
Add encoding extension support to AWS S3 exporter.

**Link to tracking Issue:**
Fixes #30554

**Testing:**
Unit tests.

**Documentation:**
README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atoulme atoulme

Labels
enhancement New feature or request exporter/awss3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/awss3] use encoding extensions atoulme/opentelemetry-collector-contrib
2 participants
@atoulme @crobert-1