Datadog Receiver does not collect service.version #30526
Labels
Comments
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
@boostchicken, are you interested in picking this up? |
jpkrohling
pushed a commit
that referenced
this issue
Feb 1, 2024
…ectly (#30225) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR sets the AppVersion property for the default fallthrough case if it exists on any spans in the request. This allows it to properly propagate through to Datadog. Currently, if using a library such as datadog/dd-trace-dotnet , the datadog service version property (dd_version) does not propagate through to datadog at all. The bug that this fixes is that the Datadog version resource attribute is currently not flowing through. **Link to tracking Issue:** <Issue number if applicable> Closes #30526 **Testing:** <Describe what testing was performed and which tests were added.> Local testing using delve to confirm expected behavior, added existing version tag to tests. Deployed patch internally on OpenTelemetry collector and observed desired behavior. **Documentation:** <Describe the documentation added.>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this issue
Feb 1, 2024
…ectly (open-telemetry#30225) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR sets the AppVersion property for the default fallthrough case if it exists on any spans in the request. This allows it to properly propagate through to Datadog. Currently, if using a library such as datadog/dd-trace-dotnet , the datadog service version property (dd_version) does not propagate through to datadog at all. The bug that this fixes is that the Datadog version resource attribute is currently not flowing through. **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#30526 **Testing:** <Describe what testing was performed and which tests were added.> Local testing using delve to confirm expected behavior, added existing version tag to tests. Deployed patch internally on OpenTelemetry collector and observed desired behavior. **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
receiver/datadog
What happened?
Description
The Datadog Receiver does not pick up the service version correctly from Datadog spans.
Steps to Reproduce
Use dd-trace-dotnet with DD_VERSION set. Send trace spans to the DD receiver.
Expected Result
The DD receiver should collect service.version correctly.
Actual Result
The DD receiver does not pickup the service version from the datadog spans.
Collector version
v0.92.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: