-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distro should include owners #28628
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Sounds good to me. To complete this we'll also need to add automation to ping the distribution owners when necessary. Do we want labels for each distribution as well? We can use that as the event to ping the relevant owners. Maybe something of the form |
Sounds like a good idea 👍 |
I like the label idea... I don't know how often we would end up using it. The only changes I can think of that are distro specific are changes to readme files to include a component in a distro, which i don't know if it opens often enough to warrant automation. |
I propose the following: we will create a file describing the contents of a distro generated via mdatagen, and have a CODEOWNERS entry generated from the owners of the distribution so we can tag anyone managing a specific distribution and make sure to notify them of any changes to their distribution. |
**Description:** Adds a set of distribution reports that can be used to notify distribution maintainers of any changes to distributions. **Link to tracking Issue:** Fixes #28628
Component(s)
cmd/mdatagen
Describe the issue you're reporting
There's a list of distros available in mdatagen:
opentelemetry-collector-contrib/cmd/mdatagen/statusdata.go
Lines 14 to 24 in 5e285f0
However, this list doesn't include any owners. This makes it difficult to review PRs that include adding a component to any particular distro. I propose that owners should be listed, much like code owners for each of the listed distro.
The text was updated successfully, but these errors were encountered: