Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test - awsemfexporter.TestIntDataPointSliceAt #2792

Closed
djaglowski opened this issue Mar 19, 2021 · 1 comment · Fixed by #2826
Closed

Flaky Test - awsemfexporter.TestIntDataPointSliceAt #2792

djaglowski opened this issue Mar 19, 2021 · 1 comment · Fixed by #2826
Assignees
Labels
bug Something isn't working flaky test a test is flaky

Comments

@djaglowski
Copy link
Member

Failing in CI, example here

--- FAIL: TestIntDataPointSliceAt (3.03s)
    --- FAIL: TestIntDataPointSliceAt/w/_2nd_rate_calculation (1.01s)
        datapoint_test.go:310: 
            	Error Trace:	datapoint_test.go:310
            	Error:      	Max difference between 1 and 0.9891196834817013 allowed is 0.01, but difference was 0.010880316518298683
            	Test:       	TestIntDataPointSliceAt/w/_2nd_rate_calculation
logEvents[0].Timestamp=5577006791947779410.
logEvents[1].Timestamp=8674665223082153551.
logEvents[2].Timestamp=6129484611666145821.
logEvents[3].Timestamp=4037200794235010051.
logEvents[4].Timestamp=3916589616287113937.
logEvents[5].Timestamp=6334824724549167320.
logEvents[6].Timestamp=605394647632969758.
logEvents[7].Timestamp=1443635317331776148.
logEvents[8].Timestamp=894385949183117216.
logEvents[9].Timestamp=2775422040480279449.
logEvents[0].Timestamp=605394647632969758, logEvents[1].Timestamp=894385949183117216.
logEvents[1].Timestamp=894385949183117216, logEvents[2].Timestamp=1443635317331776148.
logEvents[2].Timestamp=1443635317331776148, logEvents[3].Timestamp=2775422040480279449.
logEvents[3].Timestamp=2775422040480279449, logEvents[4].Timestamp=3916589616287113937.
logEvents[4].Timestamp=3916589616287113937, logEvents[5].Timestamp=4037200794235010051.
logEvents[5].Timestamp=4037200794235010051, logEvents[6].Timestamp=5577006791947779410.
logEvents[6].Timestamp=5577006791947779410, logEvents[7].Timestamp=6129484611666145821.
logEvents[7].Timestamp=6129484611666145821, logEvents[8].Timestamp=6334824724549167320.
logEvents[8].Timestamp=6334824724549167320, logEvents[9].Timestamp=8674665223082153551.
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter	16.711s
@djaglowski djaglowski added the bug Something isn't working label Mar 19, 2021
@tigrannajaryan
Copy link
Member

@anuraaga @shaochengwang @mxiamxia can you please have a look as codeowners? It is causing CI build failures.

tigrannajaryan pushed a commit that referenced this issue Mar 23, 2021
Loosen comparison of floating point a bit since sometimes it's just off

**Link to tracking Issue:** Fixes #2792 

@mxiamxia Please check to see if this delta makes any sense - I noticed the flaky behavior is still quite close to 0.01, 0.0108, so it seems like it's probably OK at a glance.
pmatyjasek-sumo referenced this issue in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Loosen comparison of floating point a bit since sometimes it's just off

**Link to tracking Issue:** Fixes #2792 

@mxiamxia Please check to see if this delta makes any sense - I noticed the flaky behavior is still quite close to 0.01, 0.0108, so it seems like it's probably OK at a glance.
@mx-psi mx-psi added the flaky test a test is flaky label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky test a test is flaky
Projects
None yet
5 participants