-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/clickhouse] Add persistent queue configuration to clickhouseexporter #27653
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
It's unclear to me why the queue in this exporter was implemented in such a hardcoded way. It seems pretty reasonable to make it support the whole set of queue configurations. @fredthomsen do you want to submit a PR? |
@dmitryax I had the same question, and yes, I will submit a PR. |
Removing |
Addresses #27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
…8579) Addresses open-telemetry#27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
…8579) Addresses open-telemetry#27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
Component(s)
exporter/clickhouse
Is your feature request related to a problem? Please describe.
Currently the clickhouseexporter only supports setting
QueueSize
fromexporterhelper.QueueSettings
: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/clickhouseexporter/config.go#L81, thus in the event of the collector going down, data queued for export is not persisted.Describe the solution you'd like
Update clickhouseexporter configuration to add the ability to specify
*component.ID
to enable persistence.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: