Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] TestFindFilesWithIOErrors is failing on Windows #27063

Closed
dmitryax opened this issue Sep 21, 2023 · 2 comments · Fixed by #27065
Closed

[pkg/stanza] TestFindFilesWithIOErrors is failing on Windows #27063

dmitryax opened this issue Sep 21, 2023 · 2 comments · Fixed by #27065
Labels
bug Something isn't working flaky test a test is flaky os:windows pkg/stanza priority:p2 Medium

Comments

@dmitryax
Copy link
Member

dmitryax commented Sep 21, 2023

Looks like it's failing on every build for the last couple days:

--- FAIL: TestFindFilesWithIOErrors (1.48s)
    --- FAIL: TestFindFilesWithIOErrors/failed_pattern_should_not_affect_others (0.02s)
        finder_test.go:249: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/finder/finder_test.go:249
            	Error:      	An error is expected but got nil.
            	Test:       	TestFindFilesWithIOErrors/failed_pattern_should_not_affect_others
        finder_test.go:250: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/finder/finder_test.go:250
            	Error:      	Not equal: 
            	            	expected: []string{"1.log", "2.log", "dir1/1.log", "dir1/2.log"}
            	            	actual  : []string{"1.log", "2.log", "no_permission\\1.log", "no_permission\\2.log", "dir1\\1.log", "dir1\\2.log"}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,6 +1,8 @@
            	            	-([]string) (len=4) {
            	            	+([]string) (len=6) {
            	            	  (string) (len=5) "1.log",
            	            	  (string) (len=5) "2.log",
            	            	- (string) (len=10) "dir1/1.log",
            	            	- (string) (len=10) "dir1/2.log"
            	            	+ (string) (len=19) "no_permission\\1.log",
            	            	+ (string) (len=19) "no_permission\\2.log",
            	            	+ (string) (len=10) "dir1\\1.log",
            	            	+ (string) (len=10) "dir1\\2.log"
            	            	 }
            	Test:       	TestFindFilesWithIOErrors/failed_pattern_should_not_affect_others
    --- FAIL: TestFindFilesWithIOErrors/partial_failure_of_FindFiles (0.00s)
        finder_test.go:249: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/finder/finder_test.go:249
            	Error:      	An error is expected but got nil.
            	Test:       	TestFindFilesWithIOErrors/partial_failure_of_FindFiles
        finder_test.go:250: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/finder/finder_test.go:250
            	Error:      	Not equal: 
            	            	expected: []string{"1.log", "2.log", "dir1/1.log", "dir1/2.log"}
            	            	actual  : []string{"1.log", "2.log", "dir1\\1.log", "dir1\\2.log", "no_permission\\1.log", "no_permission\\2.log"}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,6 +1,8 @@
            	            	-([]string) (len=4) {
            	            	+([]string) (len=6) {
            	            	  (string) (len=5) "1.log",
            	            	  (string) (len=5) "2.log",
            	            	- (string) (len=10) "dir1/1.log",
            	            	- (string) (len=10) "dir1/2.log"
            	            	+ (string) (len=10) "dir1\\1.log",
            	            	+ (string) (len=10) "dir1\\2.log",
            	            	+ (string) (len=19) "no_permission\\1.log",
            	            	+ (string) (len=19) "no_permission\\2.log"
            	            	 }
            	Test:       	TestFindFilesWithIOErrors/partial_failure_of_FindFiles
@dmitryax dmitryax added bug Something isn't working flaky test a test is flaky os:windows pkg/stanza needs triage New item requiring triage labels Sep 21, 2023
@github-actions
Copy link
Contributor

Pinging code owners for pkg/stanza: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax dmitryax removed the needs triage New item requiring triage label Sep 21, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky test a test is flaky os:windows pkg/stanza priority:p2 Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant