-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Connectors when using Cfgmetadatagen #26990
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I am in favor of this |
I have submitted a draft PR (#29001), but it turns out that
I think maybe we can treat non-defined types as empty config and skip the comment search for them. 🤔 |
I would be in favor of just fixing the forward connector by defining a
which I think should fix things? |
**Description:** `cmd/configschema` currently doesn't work with anonymous config struct. (see open-telemetry/opentelemetry-collector-contrib#26990 (comment)) This PR refactors `forwardconnector` to use a defined struct for config.
**Description:** include connectors **Link to tracking Issue:** resolve #26990 --------- Co-authored-by: Pablo Baeyens <[email protected]>
**Description:** include connectors **Link to tracking Issue:** resolve open-telemetry#26990 --------- Co-authored-by: Pablo Baeyens <[email protected]>
Component(s)
cmd/configschema
Is your feature request related to a problem? Please describe.
As part of a tool have built I use the cfgmetadatagen to generate metadata for the component configs but it does not generate metadata for connectors. Most connectors don't require any additional config, but the countconnector and spanmetricsconnector do require additional config.
Describe the solution you'd like
I would like connectors to be included when generating metadata with the cfgmetadatagen.
Describe alternatives you've considered
I am currently using regex to parse the source files, a solution I was using for all components until I discovered the cfgmetadatagen. I am now refactoring my app to use cfgmetadatagen, but it would be great to have a consistent format from which to get config fields and default values.
Additional context
It seems that this would be a fairly trivial addition, but I could be wrong. I am a Go novice so I could potentially create a PR for this, but if this is deemed a valid feature request it would be great if someone more competent with Go could add the feature.
The text was updated successfully, but these errors were encountered: