[receiver/kubeletstats] tls verify config not being respected

[jinja2]

Component(s)

receiver/kubeletstats

What happened?

Description

The receiver exposes the config InsecureSkipVerify which let's user decide if the receiver should verify the server's certificate chain and hostname. The documentation implies that this config is respected for all modes of auth_type but it is not respected with the auth mode service_account where is it set to true always

Steps to Reproduce

Expected Result

insecure_skip_verify option should be honored when the auth mode with kubelet is service_account

Actual Result

insecure_skip_verify option is not used when the auth mode with kubelet is service_account

Collector version

latest

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• receiver/kubeletstats: @dmitryax @TylerHelmuth

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

This was originally introduced in #324. All examples in the original PR set insecure_skip_verify: true, but there aren't any comments on why. There is an example config used in testing that technically hits this case, but it just makes sure the config is valid, it doesn't check the end value.

The solution here is to either honor the insecure_skip_verify setting, or include reasoning in documentation for why it's always ignored.

[crobert-1]

/label -needs-triage

[crobert-1]

I checked with the original author and it sounds like this wasn't intentional, so the solution will be to honor the insecure_skip_verify setting.

[jinja2]

Thank you @crobert-1! You can assign this to me.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/kubeletstats: @dmitryax @TylerHelmuth

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Fixed by #27070. Thanks @jinja2!