[exporter/dataset] TestConsumeLogsShouldSucceed fails on Windows

[dmitryax]

Seen in

• https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5800929161/job/15724084797
• https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5800929161/job/15724084797

go test -race -timeout 300s -parallel 4 --tags="" ./...
--- FAIL: TestConsumeLogsShouldSucceed (2.19s)
    logs_exporter_test.go:461: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_test.go:461
        	Error:      	Not equal: 
        	            	expected: add_events.AddEventsRequest{AuthParams:request.AuthParams{Token:"key-lib", Message:""}, AddEventsRequestParams:add_events.AddEventsRequestParams{Session:"85c4f802-2ee2-489a-98a9-c00c730ad2e3-d41d8cd98f00b204e9800998ecf8427e", SessionInfo:(*add_events.SessionInfo)(0xc0000a3b00), Events:[]*add_events.Event{(*add_events.Event)(0x1a038c0), (*add_events.Event)(0xc000088550), (*add_events.Event)(0xc0000885a0), (*add_events.Event)(0xc0000885f0)}, Threads:[]*add_events.Thread{(*add_events.Thread)(0x19ea860)}, Logs:[]*add_events.Log{(*add_events.Log)(0x19e8cb0)}}}
        	            	actual  : add_events.AddEventsRequest{AuthParams:request.AuthParams{Token:"key-lib", Message:""}, AddEventsRequestParams:add_events.AddEventsRequestParams{Session:"85c4f802-2ee2-489a-98a9-c00c730ad2e3-d41d8cd98f00b204e9800998ecf8427e", SessionInfo:(*add_events.SessionInfo)(0xc0000a3b00), Events:[]*add_events.Event{(*add_events.Event)(0xc000088460), (*add_events.Event)(0xc0000884b0)}, Threads:[]*add_events.Thread{(*add_events.Thread)(0xc000094520)}, Logs:[]*add_events.Log{(*add_events.Log)(0xc000097170)}}}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -12,37 +12,3 @@
        	            	   }),
        	            	-  Events: ([]*add_events.Event) (len=4) {
        	            	-   (*add_events.Event)({
mingw32-make[2]: *** [../../Makefile.Common:100: test] Error 1
mingw32-make[1]: *** [makefile:176: exporter/datasetexporter] Error 2
mingw32-make[1]: *** Waiting for unfinished jobs....
        	            	-    Thread: (string) (len=2) "TL",
        	            	-    Sev: (int) 3,
        	            	-    Ts: (string) (len=19) "1581452773000000789",
        	            	-    Log: (string) (len=2) "LL",
        	            	-    Attrs: (map[string]interface {}) (len=8) {
        	            	-     (string) (len=16) "__origServerHost": (string) (len=3) "foo",
        	            	-     (string) (len=3) "app": (string) (len=6) "server",
        	            	-     (string) (len=10) "bundle_key": (string) (len=32) "d41d8cd98f00b204e9800998ecf8427e",
        	            	-     (string) (len=24) "dropped_attributes_count": (float64) 1,
        	            	-     (string) (len=12) "instance_num": (float64) 1,
        	            	-     (string) (len=7) "message": (string) (len=21) "This is a log message",
        	            	-     (string) (len=7) "span_id": (string) (len=16) "0102040800000000",
        	            	-     (string) (len=8) "trace_id": (string) (len=32) "08040201000000000000000000000000"
        	            	-    },
        	            	-    ServerHost: (string) ""
        	            	-   }),
        	            	-   (*add_events.Event)({
        	            	-    Thread: (string) (len=2) "TL",
        	            	-    Sev: (int) 3,
        	            	-    Ts: (string) (len=19) "1581452773000000789",
        	            	-    Log: (string) (len=2) "LL",
        	            	-    Attrs: (map[string]interface {}) (len=8) {
        	            	-     (string) (len=16) "__origServerHost": (string) (len=23) "serverHostFromAttribute",
        	            	-     (string) (len=3) "app": (string) (len=6) "server",
        	            	-     (string) (len=10) "bundle_key": (string) (len=32) "d41d8cd98f00b204e9800998ecf8427e",
        	            	-     (string) (len=24) "dropped_attributes_count": (float64) 1,
        	            	-     (string) (len=12) "instance_num": (float64) 1,
        	            	-     (string) (len=7) "message": (string) (len=21) "This is a log message",
        	            	-     (string) (len=7) "span_id": (string) (len=16) "0102040800000000",
        	            	-     (string) (len=8) "trace_id": (string) (len=32) "08040201000000000000000000000000"
        	            	-    },
        	            	-    ServerHost: (string) ""
        	            	-   }),
        	            	+  Events: ([]*add_events.Event) (len=2) {
        	            	    (*add_events.Event)({
        	Test:       	TestConsumeLogsShouldSucceed
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter	2.340s

[github-actions]

Pinging code owners for exporter/dataset: @atoulme @martin-majlis-s1 @zdaratom @tomaz-s1. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

Pinging code owners:

• exporter/dataset: @atoulme @martin-majlis-s1 @zdaratom @tomaz-s1

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[martin-majlis-s1]

@dmitryax : Thanks for bringing this into our attention. We will take a look.

When I check last 15 failures of build-and-test-windows - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test-windows.yml?query=is%3Afailure - I can see, that exporter is almost always skipped (S), because some other test has already failed (F). There isn't any single example where exporter would pass (P) and something else has failed (F).

receiver : FSSSSSSSPFSSSSS
processor: ???????FPSFPSFP
exporter : SSFSSSFSFSSFFSF
internal : ???FFFPPPSSPPPP
pkg      : ?FPPPSPPPSSPPPP

[dmitryax]

Yes, there are some other flaky tests on Windows. I'm trying to clean this up

[martin-majlis-s1]

I have run two batches of 60 tests on Windows machine. In each of these batches just one test has failed.
When I do something similar on my Mac, all of them succeeds.

I have introduced unit tests for windows - scalyr/dataset-go#50 - but they are failing.

These failures were limited to some timing issues - since on Windows some of the tests run significantly slower.

[dmitryax]

Fixed by #25143