Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/k8sobjects] Allow specifying whether DELETE actions should be ingested during a watch #24904

Closed
TylerHelmuth opened this issue Aug 4, 2023 · 2 comments · Fixed by #26042
Closed

[receiver/k8sobjects] Allow specifying whether DELETE actions should be ingested during a watch #24904

TylerHelmuth opened this issue Aug 4, 2023 · 2 comments · Fixed by #26042
Labels
enhancement New feature or request priority:p2 Medium receiver/k8sobjects

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Aug 4, 2023 •
edited
Loading

Component(s)

No response

Is your feature request related to a problem? Please describe.

At the moment the receiver ingests any object update sent to it during a watch. One of these update types is a DELETE. While occasionally interesting, this type of update is not always needed by a user. For event ingestion, for example, a DELETE option is less useful if the user is only looking for the stream of events that happened in the cluster and is not interested in the cluster's internal management of those events.

Describe the solution you'd like

A new configuration option that allows excluding DELETE types from watches. We could go 1 step further and allow users to specify exactly which operations (ADDED, UPDATED, DELETED, BOOKMARK) the watch should ingest.

Additional context

A feature like this is necessary for #24242 since the k8seventsreceiver does not include DELETE updates.
@TylerHelmuth TylerHelmuth added enhancement New feature or request needs triage New item requiring triage priority:p2 Medium receiver/k8sobjects and removed needs triage New item requiring triage labels Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Pinging code owners for receiver/k8sobjects: @dmitryax @hvaghani221. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth TylerHelmuth mentioned this issue Aug 4, 2023
Closed
@TylerHelmuth TylerHelmuth mentioned this issue Aug 22, 2023
Merged
jpkrohling pushed a commit that referenced this issue Sep 5, 2023
@TylerHelmuth
[receiver/k8sobjects] Add ability to exclude deleted updates for watc…
930b421 
…hed objects (#26042)

**Description:** 
Adds a new configuration option that allows excluding `DELETED` updates
for watched objects.

**Link to tracking Issue:** 
Closes
#24904

**Testing:** 
New unit tests and tested locally

**Documentation:**
Updated the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:p2 Medium receiver/k8sobjects
Projects
None yet
Milestone
No milestone
1 participant
@TylerHelmuth