[pkg/stanza] Upgrade to github.com/antonmedv/expr v1.12.7 breaks tests

[songy23]

Component(s)

pkg/stanza

What happened?

See CI failure: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5650490793/job/15307018157?pr=24536

To reproduce, update github.com/antonmedv/expr to v1.12.7 in pkg/stanza/go.mod, then run the tests with make test.

Collector version

n/a

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• pkg/stanza: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[djaglowski]

It looks like the expr module added a new key word, "env" to its grammar.

Unfortunately, we already had added some custom behavior for the same keyword.

The test failures quite clearly appear to be related:

--- FAIL: TestAttributer (0.00s)
    --- FAIL: TestAttributer/AddAttributeEnv (0.00s)
        attributer_test.go:85: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/operator/helper/attributer_test.go:85
            	Error:      	Received unexpected error:
            	            	render embedded expression: reflect: call of reflect.Value.Call on map Value (1:1)
            	            	 | env("TEST_METADATA_OPERATOR_ENV")
            	            	 | ^
            	Test:       	TestAttributer/AddAttributeEnv
--- FAIL: TestExprString (0.00s)
    --- FAIL: TestExprString/12 (0.00s)
        expr_string_test.go:100: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/operator/helper/expr_string_test.go:100
            	Error:      	Received unexpected error:
            	            	render embedded expression: reflect: call of reflect.Value.Call on map Value (1:1)
            	            	 | env('TEST_EXPR_STRING_ENV')
            	            	 | ^
            	Test:       	TestExprString/12
--- FAIL: TestIdentifier (0.00s)
    --- FAIL: TestIdentifier/AddAttributeEnv (0.00s)
        identifier_test.go:85: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/operator/helper/identifier_test.go:85
            	Error:      	Received unexpected error:
            	            	render embedded expression: reflect: call of reflect.Value.Call on map Value (1:1)
            	            	 | env("TEST_METADATA_OPERATOR_ENV")
            	            	 | ^
            	Test:       	TestIdentifier/AddAttributeEnv
--- FAIL: TestTransformer (0.00s)
    --- FAIL: TestTransformer/NoMatchEnv (0.00s)
        logger.go:130: 2023-07-24T22:42:41.909Z	ERROR	Running expressing returned an error%!(EXTRA zapcore.Field={error 26 0  reflect: call of reflect.Value.Call on map Value (1:1)
             | env("TEST_FILTER_OPERATOR_ENV") == "bar"
             | ^})	{"operator_id": "test", "operator_type": "filter"}
        filter_test.go:178: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/filter/filter_test.go:178
            	Error:      	Not equal: 
            	            	expected: false
            	            	actual  : true
            	Test:       	TestTransformer/NoMatchEnv
--- FAIL: TestTransformer (0.01s)
    --- FAIL: TestTransformer/MatchEnv (0.00s)
        router_test.go:215: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/router/router_test.go:215
            	Error:      	Not equal: 
            	            	expected: map[string]int{"output1":1}
            	            	actual  : map[string]int{"output2":1}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,3 +1,3 @@
            	            	 (map[string]int) (len=1) {
            	            	- (string) (len=7) "output1": (int) 1
            	            	+ (string) (len=7) "output2": (int) 1
            	            	 }
            	Test:       	TestTransformer/MatchEnv

I'm looking into it, but we likely need to lock in the version of the module for now.

[antonmedv]

Hmm. env is very popular keyword. I will change it to something less popular.