Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/exceptions] Relate generated metrics from the source trace/span #24409

Closed
marctc opened this issue Jul 20, 2023 · 9 comments · Fixed by #31819
Closed

[connector/exceptions] Relate generated metrics from the source trace/span #24409

marctc opened this issue Jul 20, 2023 · 9 comments · Fixed by #31819
Assignees
@marctc
Labels
connector/exceptions enhancement New feature or request

Comments

@marctc
Copy link
Contributor

marctc commented Jul 20, 2023

Component(s)

No response

Is your feature request related to a problem? Please describe.

The current implementation generates metrics from recorded exceptions in spans, but is not possible to see which traces and spans generated those metrics.

Describe the solution you'd like

It would be useful to correlate spans to generated metrics, specially for debugging purpouse during outages. Using exemplars with the generated metrics would this make work.

Describe alternatives you've considered

No response

Additional context

No response
@marctc marctc added enhancement New feature or request needs triage New item requiring triage labels Jul 20, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Sep 3, 2023
Open
Open
This was referenced Sep 6, 2023
Open
Open
This was referenced Sep 12, 2023
Open
Open
@github-actions github-actions bot mentioned this issue Sep 19, 2023
Open
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • needs: Github issue template generation code needs this to generate the corresponding labels.
  • connector/exceptions: @jpkrohling

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 19, 2023
This was referenced Sep 26, 2023
Open
Closed
This was referenced Oct 3, 2023
Open
Closed
@crobert-1
Copy link
Member

Removing needs triage as this was filed by the original author of the component.

@crobert-1 crobert-1 removed Stale needs triage New item requiring triage labels Oct 12, 2023
@crobert-1
Copy link
Member

@marctc Would you be interested in being a code owner for this component, seeing as you're the main contributor here? It would be great to get some more help on this if you have the availability!

@marctc
Copy link
Contributor Author

marctc commented Oct 13, 2023

@marctc Would you be interested in being a code owner for this component, seeing as you're the main contributor here

Yes, definitely. But I think I have to be maintainer, first right? In any case, I'm interested in both. Thanks!

@crobert-1
Copy link
Member

You just have to be a member. The directions for joining are there, it looks like you should meet them without a problem 👍

Once you're a member you can open a PR to add yourself as a code owner here.

@marctc marctc mentioned this issue Oct 30, 2023
Closed
6 tasks
@crobert-1 crobert-1 mentioned this issue Dec 7, 2023
Merged
codeboten pushed a commit that referenced this issue Dec 7, 2023
@crobert-1
[chore][connector/exceptions] Add @marctc as code owner (#29692)
3a0c2b7 
@marctc is the original component proposer and author, and is now a
[member of the OpenTelemetry
community](open-telemetry/community#1761). He
also [expressed interest in being a code
owner](#24409 (comment))
when I asked.
jayasai470 pushed a commit to jayasai470/opentelemetry-collector-contrib that referenced this issue Dec 8, 2023
@crobert-1 @jayasai470
[chore][connector/exceptions] Add @marctc as code owner (open-telemet…
5364dde 
…ry#29692)

@marctc is the original component proposer and author, and is now a
[member of the OpenTelemetry
community](open-telemetry/community#1761). He
also [expressed interest in being a code
owner](open-telemetry#24409 (comment))
when I asked.
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Dec 13, 2023
@crobert-1 crobert-1 removed the Stale label Dec 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 12, 2024
@jpkrohling jpkrohling removed the Stale label Feb 14, 2024
@marctc marctc mentioned this issue Mar 18, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 15, 2024
@crobert-1 crobert-1 removed the Stale label Apr 15, 2024
jpkrohling added a commit that referenced this issue May 24, 2024
@marctc @jpkrohling
[connector/exceptions] Add support for exemplars in exceptionsconnect…
4fad287 
…or (#31819)

**Description:** <Describe what has changed.>
Adds support for exemplars fort the generated metrics from exceptions.
It relates the span and trace id with metrics.

The ingestion needs to be enabled via config (disbled by default).

**Link to tracking Issue:**  Resolves #24409

**Documentation:** Added documentation for enabling generation of
exemplars.

---------

Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marctc marctc

Labels
connector/exceptions enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@jpkrohling @marctc @crobert-1