Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Prometheus receiver has unused buffer config options #24258

Closed
dashpole opened this issue Jul 13, 2023 · 2 comments · Fixed by #24257
Closed

Cleanup: Prometheus receiver has unused buffer config options #24258

dashpole opened this issue Jul 13, 2023 · 2 comments · Fixed by #24257
Labels
needs triage New item requiring triage receiver/prometheus Prometheus receiver

Comments

@dashpole
Copy link
Contributor

Component(s)

receiver/prometheus

Describe the issue you're reporting

Found while adding documentation for #24256. The prometheus receiver had two config options that AFAICT have never been used.

The config options have existed since the very first commit ever for the Prometheus receiver: 7c728ef

We should remove those configuration options.
@dashpole dashpole added needs triage New item requiring triage receiver/prometheus Prometheus receiver labels Jul 13, 2023
@crobert-1
Copy link
Member

You're referring to buffer_period and buffer_count, right? Reference here.

Just want to make it clear for future reference.

@dashpole dashpole mentioned this issue Jul 14, 2023
Merged
@dashpole
Copy link
Contributor Author

Yes, see #24257

dmitryax added a commit that referenced this issue Jul 21, 2023
@dashpole @dmitryax
prometheusreceiver: remove unused buffer_period and buffer_count conf…
20b3071 
…iguration options (#24257)

**Description:**

Fixes #24258

Found while adding documentation for
#24256.
The prometheus receiver had two config options that AFAICT have never
been used.

The config options have existed since the very first commit ever for the
Prometheus receiver:
7c728ef


Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage New item requiring triage receiver/prometheus Prometheus receiver
Projects
None yet
Milestone
No milestone
2 participants
@dashpole @crobert-1