Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/carbonreceiver] move to create the server resource as part of start #17404

Closed
atoulme opened this issue Jan 6, 2023 · 1 comment
Closed
Labels
bug Something isn't working needs triage New item requiring triage

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 6, 2023

Component(s)

receiver/carbon

What happened?

Description

The carbon receiver creates a server resource in its New method. While it doesn't start it before the Start method, it is better to move it to Start so we can control the resource as part of the lifecycle of the component.

See #17400 for bigger context.

Collector version

0.68.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@atoulme atoulme added bug Something isn't working needs triage New item requiring triage labels Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

2 participants