Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all components can shutdown even if skip lifecycle is set. #17400

Closed
atoulme opened this issue Jan 6, 2023 · 3 comments
Closed

Make sure all components can shutdown even if skip lifecycle is set. #17400

atoulme opened this issue Jan 6, 2023 · 3 comments
Labels
bug Something isn't working needs triage New item requiring triage

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 6, 2023

Component(s)

No response

What happened?

Description

In #17199, we added support for checking that components would behave properly if shutdown before starting. But this doesn't extend to components which are marked as skipped as their lifecycle is not fit for tests.

For this test, we should disregard this flag and extend the test to all components.

See signalfx/splunk-otel-collector-chart#623 for an occurrence of the issue with k8sclusterreceiver.

Collector version

0.67.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@frzifus
Copy link
Member

frzifus commented Jan 6, 2023

Is there an easy check to see which components are effected?

@atoulme
Copy link
Contributor Author

atoulme commented Jan 6, 2023

Click on the PRs associated and look at the labels. They contain the names of components affected.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 6, 2023

This is now fixed. Onwards!

@atoulme atoulme closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

2 participants