Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Jaeger Kafka Exporter #125

Closed
joe-elliott opened this issue Feb 12, 2020 · 9 comments
Closed

Add Support for Jaeger Kafka Exporter #125

joe-elliott opened this issue Feb 12, 2020 · 9 comments

Comments

@joe-elliott
Copy link
Contributor

As discussed here: open-telemetry/opentelemetry-collector#500

Jaeger Kafka exporter support should be added to the collector through the contrib repo.

@yurishkuro
Copy link
Member

What is the mechanism used to pull contrib code into the main binary?

@tigrannajaryan
Copy link
Member

What is the mechanism used to pull contrib code into the main binary?

@yurishkuro by adding a factory here: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/master/cmd/otelcontribcol/components.go

@pavolloffay
Copy link
Member

As an experiment, I have built https://github.com/jaegertracing/jaeger-opentelemetry-collector. At the moment it only includes Jaeger Elasticsearch exporter and the set of the default components. It might be easier to directly build the OTEL collector in the main Jaeger repository - it does not have to be hosted separately.

We should decide where Jaeger storage exporters will live. It depends if we want to add Jaeger specific functionality to the collector. For example one of the missing features is serving sampling strategies.

@joe-elliott
Copy link
Contributor Author

@pavolloffay
I am working on sampling strategies now to resolve this issue: open-telemetry/opentelemetry-collector#500

@yurishkuro
Copy link
Member

It might be easier to directly build the OTEL collector in the main Jaeger repository

+1

@tigrannajaryan
Copy link
Member

@yurishkuro @pavolloffay I am happy to see you are building on top of OpenTelemetry Collector. Do you mind sharing a bit more about what you plan to do? It would be great to know how the Collector is used by Jaeger.

@joe-elliott
Copy link
Contributor Author

Per discussions with Jaeger this functionality is being implemented in https://github.com/jaegertracing/jaeger-opentelemetry-collector and probably does not make sense to implement here as well.

@ledor473, I believe that once jaeger-opentelemetry-collector is up to date with master (for the sampling json) and they add the Kafka exporter this project will meet your needs.

cc @pavolloffay

@pavolloffay
Copy link
Member

+1 on what @joe-elliott said. I will just add that in Jaeger we are considering supporting OTEL proto as a first-class citizen. Therefore the contrib repository could provide kafka exporter and in the Jaeger collector there will be an importer for kafka in OT proto format.

@tigrannajaryan
Copy link
Member

Per discussions with Jaeger this functionality is being implemented in https://github.com/jaegertracing/jaeger-opentelemetry-collector and probably does not make sense to implement here as well.

Closing this issue as there is nothing else needed to be done in this repo.

bogdandrutu pushed a commit that referenced this issue May 12, 2022
* extract multiline from file input and move to helper

Signed-off-by: Dominik Rosiek <[email protected]>

* extract encoding from file input and move to helper

Signed-off-by: Dominik Rosiek <[email protected]>

* tcp: add multiline

Signed-off-by: Dominik Rosiek <[email protected]>

* Rename max_buffer_size to max_log_size

* tcp: rename MaxBufferSize to MaxLogSize

Signed-off-by: Dominik Rosiek <[email protected]>

* Update tcp operator documentation

* Fxi handling multiline for EOF

* Optionally flush multilines for closed connections

* Return splitFunc by multiline helper

* Add decode method to encoding helper

Signed-off-by: Dominik Rosiek <[email protected]>

* Refactor encoding helper

Signed-off-by: Dominik Rosiek <[email protected]>
codeboten pushed a commit that referenced this issue Nov 23, 2022
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Feb 9, 2024
…lemetry#125)

* added a new chloggen for cwa

* added issue in yaml

* added issue in yaml

* added issue in yaml

* edited the changelog.yml trigger

* edited the changelog.yml trigger

* added the auto changelog update

* updated the changelog-update

* updated according to PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants