PR review

Signed-off-by: odubajDT <[email protected]>
open-telemetry · Oct 2, 2024 · dd92610 · dd92610
1 parent 8266af8
commit dd92610
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/internal/metadataproviders/kubeadm/metadata.go b/internal/metadataproviders/kubeadm/metadata.go
@@ -14,7 +14,7 @@ import (
 )
 
 type Provider interface {
-	// ClusterName returns the current K8S Node Name
+	// ClusterName returns the current K8S cluster name
 	ClusterName(ctx context.Context) (string, error)
 }
 

diff --git a/processor/resourcedetectionprocessor/README.md b/processor/resourcedetectionprocessor/README.md
@@ -531,7 +531,7 @@ rules:
 
 ### K8S Node Metadata
 
-Queries the K8S api server to retrieve the following node resource attributes:
+Queries the K8S API server to retrieve the following resource attributes:
 
     * k8s.node.uid
     * k8s.node.name

diff --git a/processor/resourcedetectionprocessor/internal/kubeadm/kubeadm.go b/processor/resourcedetectionprocessor/internal/kubeadm/kubeadm.go
@@ -36,13 +36,13 @@ func NewDetector(set processor.Settings, dcfg internal.DetectorConfig) (internal
 		return nil, err
 	}
 
-	k8snodeProvider, err := kubeadm.NewProvider(cfg.configMapName, cfg.configMapNamespace, cfg.APIConfig)
+	kubeadmProvider, err := kubeadm.NewProvider(cfg.configMapName, cfg.configMapNamespace, cfg.APIConfig)
 	if err != nil {
 		return nil, fmt.Errorf("failed creating kubeadm provider: %w", err)
 	}
 
 	return &detector{
-		provider: k8snodeProvider,
+		provider: kubeadmProvider,
 		logger:   set.Logger,
 		ra:       &cfg.ResourceAttributes,
 		rb:       metadata.NewResourceBuilder(cfg.ResourceAttributes),