gocritic: switch ifelse with case statement

open-telemetry · Sep 15, 2023 · d6ddb63 · d6ddb63
1 parent 9091f55
commit d6ddb63
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/cmd/telemetrygen/internal/metrics/worker.go b/cmd/telemetrygen/internal/metrics/worker.go
@@ -33,19 +33,21 @@ func (w worker) simulateMetrics(res *resource.Resource, exporter sdkmetric.Expor
 	var i int64
 	for w.running.Load() {
 		var metrics []metricdata.Metrics
-		if w.metricType == metricTypeGauge {
+
+		switch w.metricType {
+		case metricTypeGauge:
 			metrics = append(metrics, metricdata.Metrics{
 				Name: "gen",
 				Data: metricdata.Gauge[int64]{
 					DataPoints: []metricdata.DataPoint[int64]{
 						{
-							Time:      time.Now(),
-							Value:     i,
+							Time:  time.Now(),
+							Value: i,
 						},
 					},
 				},
 			})
-		} else if w.metricType == metricTypeSum {
+		case metricTypeSum:
 			metrics = append(metrics, metricdata.Metrics{
 				Name: "gen",
 				Data: metricdata.Sum[int64]{
@@ -60,7 +62,7 @@ func (w worker) simulateMetrics(res *resource.Resource, exporter sdkmetric.Expor
 					},
 				},
 			})
-		} else {
+		default:
 			w.logger.Fatal("unknown metric type")
 		}