Skip to content

Commit

Permalink
[exporter/signalfx] do not exclude the metric container.memory.workin…
Browse files Browse the repository at this point in the history
…g_set (#35475)

**Description:** 
Do not exclude the metric container.memory.working_set
  • Loading branch information
atoulme authored and jriguera committed Oct 4, 2024
1 parent c1d8b6d commit 8f73652
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 5 deletions.
27 changes: 27 additions & 0 deletions .chloggen/remove_exclusion_rule.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: signalfxexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Do not exclude the metric `container.memory.working_set`

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [35475]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
2 changes: 1 addition & 1 deletion exporter/signalfxexporter/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ func TestDefaultExcludes_not_translated(t *testing.T) {
require.NoError(t, err)

md := getMetrics(metrics)
require.Equal(t, 69, md.ResourceMetrics().At(0).ScopeMetrics().At(0).Metrics().Len())
require.Equal(t, 68, md.ResourceMetrics().At(0).ScopeMetrics().At(0).Metrics().Len())
dps := converter.MetricsToSignalFxV2(md)
require.Empty(t, dps)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ exclude_metrics:
- /^(?i:(container)|(k8s\.node)|(k8s\.pod))\.memory\.page_faults$/
- /^(?i:(container)|(k8s\.node)|(k8s\.pod))\.memory\.rss$/
- /^(?i:(k8s\.node)|(k8s\.pod))\.memory\.usage$/
- /^(?i:(container)|(k8s\.node)|(k8s\.pod))\.memory\.working_set$/
- /^(?i:(k8s\.node)|(k8s\.pod))\.memory\.working_set$/
# matches (k8s.node|k8s.pod).filesystem...
- /^k8s\.(?i:(node)|(pod))\.filesystem\.available$/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,6 @@
{
"container.memory.rss": null
},
{
"container.memory.working_set": null
},
{
"k8s.pod.memory.available": null
},
Expand Down

0 comments on commit 8f73652

Please sign in to comment.