Backport changes to stackdriver exporter (#19)

* Upgrade Stackdriver exporter version * Upgrade otelsvc version * Backport changes to stackdriver exporter * Update goodSpans counter * Fix import
open-telemetry · Sep 19, 2019 · 4a71131 · 4a71131
1 parent bc14ca6
commit 4a71131
Show file tree

Hide file tree

Showing 5 changed files with 89 additions and 33 deletions.
diff --git a/exporter/stackdriverexporter/config.go b/exporter/stackdriverexporter/config.go
@@ -24,4 +24,5 @@ type Config struct {
 	EnableMetrics                 bool                     `mapstructure:"enable-metrics"`
 	Prefix                        string                   `mapstructure:"metric-prefix"`
 	Endpoint                      string                   `mapstructure:"endpoint"`
+	NumOfWorkers                  int                      `mapstructure:"number-of-workers"`
 }
diff --git a/exporter/stackdriverexporter/factory.go b/exporter/stackdriverexporter/factory.go
@@ -30,8 +30,6 @@ const (
 type Factory struct {
 }
 
-var _ (exporter.Factory) = (*Factory)(nil)
-
 // Type gets the type of the Exporter config created by this factory.
 func (f *Factory) Type() string {
 	return typeStr

diff --git a/exporter/stackdriverexporter/go.mod b/exporter/stackdriverexporter/go.mod
@@ -3,10 +3,10 @@ module github.com/open-telemetry/opentelemetry-service-contrib/exporter/stackdri
 go 1.12
 
 require (
-	contrib.go.opencensus.io/exporter/stackdriver v0.12.7
-	github.com/open-telemetry/opentelemetry-service v0.0.2-0.20190904165913-41a7afa548c8
-	github.com/stretchr/testify v1.3.0
-	go.opencensus.io v0.22.1 // indirect
+	// TODO: pin a released version
+	contrib.go.opencensus.io/exporter/stackdriver v0.12.8-0.20190917133925-4339afab4a99
+	github.com/open-telemetry/opentelemetry-service v0.0.3-0.20190914010649-b38505c2306b
+	github.com/stretchr/testify v1.4.0
 	go.uber.org/zap v1.10.0
-	google.golang.org/api v0.7.0
+	google.golang.org/api v0.10.0
 )