check error on FromRaw return

open-telemetry · Jun 21, 2023 · 48dd7d9 · 48dd7d9
1 parent 7ed6cd4
commit 48dd7d9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/receiver/kafkareceiver/README.md b/receiver/kafkareceiver/README.md
@@ -12,7 +12,6 @@
 [observiq]: https://github.com/observIQ/observiq-otel-collector
 [splunk]: https://github.com/signalfx/splunk-otel-collector
 [sumo]: https://github.com/SumoLogic/sumologic-otel-collector
-
 <!-- end autogenerated section -->
 
 Kafka receiver receives traces, metrics, and logs from Kafka. Message payload encoding is configurable.

diff --git a/receiver/kafkareceiver/json_unmarshaler.go b/receiver/kafkareceiver/json_unmarshaler.go
@@ -32,8 +32,9 @@ func (r *jsonLogsUnmarshaler) Unmarshal(buf []byte) (plog.Logs, error) {
 	logRecords.SetObservedTimestamp(pcommon.NewTimestampFromTime(time.Now()))
 
 	// Set the unmarshaled jsonVal as the body of the log record
-	logRecords.Body().SetEmptyMap().FromRaw(jsonVal)
-
+	if err := logRecords.Body().SetEmptyMap().FromRaw(jsonVal); err != nil {
+		return p, err
+	}
 	return p, nil
 }
 

diff --git a/receiver/kafkareceiver/testdata/config.yaml b/receiver/kafkareceiver/testdata/config.yaml
@@ -16,7 +16,7 @@ kafka:
       backoff: 5s
 kafka/logs:
   topic: logs
-  encoding: text
+  encoding: direct
   brokers:
     - "coffee:123"
     - "foobar:456"