-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[mongodbreceiver] change 'Hosts' configuration type (#32550)
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> what changed:mongodbreceiver `Hosts` configuration use `confignet.TCPAddrConfig`. Hi master, I looked at the mongodbreceiver code: 1. The error is caused by [AddrConfig.Validate()](https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/confignet/confignet.go#L122) return error. ```go func (na *AddrConfig) Validate() error { switch na.Transport { case TransportTypeTCP, ... return nil default: return fmt.Errorf("invalid transport type %q", na.Transport) } } ``` 2. `mongodbreceiver` use [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver)to connect mongodb. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/mongodbreceiver/go.mod#L13 ```go module github.com/open-telemetry/opentelemetry-collector-contrib/receiver/mongodbreceiver go 1.21 require ( ... go.mongodb.org/mongo-driver v1.15.0 ... ) ``` 3. `go.mongodb.org/mongo-driver` based on `TCP`. https://github.com/mongodb/mongo-go-driver/blob/v1/x/mongo/driver/dns/dns.go#L82 ```go _, addresses, err := r.LookupSRV(srvName, "tcp", host) ``` So I think mongodbreceiver only supporting TCP. **Link to tracking Issue:** <Issue number if applicable> #32199 --------- Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Curtis Robert <[email protected]>
- Loading branch information
1 parent
dba9416
commit 21df779
Showing
6 changed files
with
45 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: breaking | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: mongodbreceiver | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Now only supports `TCP` connections | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [32199] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: This fixes a bug where hosts had to explicitly set `tcp` as the transport type. The `transport` option has been removed. | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters