Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app: Order confirmation #598

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

magda-woj
Copy link
Contributor

Created CheckoutConfirmation.kt with an order confirmation screen, basing it off the web demo. User sees this screen after clicking "Place Order" on the CheckoutInfo screen. The cart is also cleared in the process.
image
Additionally, I made the form for shipping and payment information pre-filled, to be able to go to that screen without filling them in every time.

@magda-woj magda-woj requested a review from a team September 16, 2024 15:03
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Thanks!

.verticalScroll(rememberScrollState())
) {
Text(
text = "Your order is complete!",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally these would be translatable strings, but for now it's perfectly fine to just have them coded.

@breedx-splk breedx-splk merged commit 864e262 into open-telemetry:main Sep 18, 2024
3 checks passed
@magda-woj magda-woj deleted the checkout-confirmation branch September 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants