Ending "Paused" span for a fragment. #591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a simple fix for the #590 issue I just submitted. However I don't know the reasoning for the current way, so I don't know if it creates new problems.
Currently
onFragmentPaused
andonFragmentStopped
add events to the same span, which is ended inonFragmentStopped
. I propose to end an active span inonFragmentPaused
and create a new one inonFragmentStopped
. With those changesPaused
for About activity is a parent ofPaused
for the last fragment and analogously withStopped
(so 2 traces with 2 spans each) . Unrelated spans get their own traces in between and after.In addition to fixing #590 this is consistent with how in Activity Lifecycle Instrumentation
Paused
andStopped
are separate spans.