Cleanup httpurlconnection androidTests #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeTheSalad
approved these changes
Aug 1, 2024
breedx-splk
reviewed
Aug 1, 2024
| } else { | ||
| // if all tasks don't finish before timeout | ||
| Assert.fail( | ||
| fail( | ||
| "Test could not be completed as tasks did not complete within the 2s timeout period.", | ||
| ) | ||
| } | ||
| } catch (e: InterruptedException) { |
There was a problem hiding this comment.
Preference is to just let the exception escape the method and the test will still fail.
breedx-splk
reviewed
Aug 1, 2024
| @@ -67,46 +70,39 @@ class InstrumentationTest { | |||
| // Wait for all tasks to finish execution or timeout | |||
| if (executor.awaitTermination(2, TimeUnit.SECONDS)) { | |||
There was a problem hiding this comment.
instead if if you can just wrap with assertTrue() and remove the else block entirely.
There was a problem hiding this comment.
Updated, That makes the code cleaner! Thanks :)
breedx-splk
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up httpurlconnection androidTests based on learnings and discussions from PR #452 and PR #500: