Nav refactor #497
Merged
Nav refactor #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magda-woj
force-pushed
the
nav-refactor
branch
2 times, most recently
from
8626d16 to
5292795
Compare
|
Product details are looking good! |
breedx-splk
reviewed
Jul 30, 2024
demo-app/src/main/java/io/opentelemetry/android/demo/ui/shop/Navigation.kt
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Jul 30, 2024
demo-app/src/main/java/io/opentelemetry/android/demo/ui/shop/AstronomyShopActivity.kt
Show resolved
Hide resolved
breedx-splk
reviewed
Jul 30, 2024
| modifier = Modifier.fillMaxWidth(), | ||
| textAlign = TextAlign.Center | ||
| ) | ||
| Spacer(modifier = Modifier.height(32.dp)) |
There was a problem hiding this comment.
TODO: in a subsequent PR, the user should be able to specify a quantity to add, typically with some kind of integer spin box.
breedx-splk
approved these changes
Jul 30, 2024
|
@open-telemetry/android-approvers would be nice to have some Splunk-external eyes on this as well. ❤️ |
LikeTheSalad
approved these changes
Jul 31, 2024
| ) { | ||
| // this.items(products) { product -> CartItem(product) } | ||
| } | ||
| // CheckoutButton(totalPrice = products.sumOf { it.price }) |
There was a problem hiding this comment.
Is there a reason for us to keep the above lines of code commented?
There was a problem hiding this comment.
they had errors and because cart screen is a placeholder now and i'll probably rewrite a lot of it anyway i forgot about fixing them, but i did now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fragments replaced with composables (with some changes to direcotry tree), navigation to product details added.