Instrumentation API part 9 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Jul 23, 2024
android-agent/src/main/java/io/opentelemetry/android/initialization/InitializationEvents.kt
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Jul 23, 2024
| import io.opentelemetry.android.config.OtelRumConfig | ||
| import io.opentelemetry.sdk.trace.export.SpanExporter | ||
|
|
||
| class TestInitializationEvents : InitializationEvents { |
There was a problem hiding this comment.
Is this the same as the noop version? Can we reuse that instead?
There was a problem hiding this comment.
It's kinda the same, though the reason I created it was for this test. So that the test can verify that the InitializationEvents.get() function does search for implementations in the classpath. If no implementation is found, then the function returns the noop impl, so that's why I couldn't use the same one for the test.
There was a problem hiding this comment.
ok, I think that makes sense then.
breedx-splk
reviewed
Jul 23, 2024
buildSrc/src/main/kotlin/otel.java-library-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Jul 23, 2024
...up/src/main/java/io/opentelemetry/android/instrumentation/startup/SdkInitializationEvents.kt
Show resolved
Hide resolved
breedx-splk
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the
startupmodule to the new instrumentation API.This is the last instrumentation module that the
android-agentmodule has a dependency on.