Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation API part 7 #465

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

LikeTheSalad
Copy link
Contributor

Continuation of the activity-fragment-lifecycle-startup migration. This part covers the fragment instrumentation implementation and removes the lifecycle module that used to be an entry point for both, activity and fragment instrumentations, but now each of them has its own entry point (AndroidInstrumentation impl).

@LikeTheSalad LikeTheSalad requested a review from a team July 3, 2024 08:27
application.registerActivityLifecycleCallbacks(buildFragmentRegisterer(openTelemetryRum))
}

private fun buildFragmentRegisterer(openTelemetryRum: OpenTelemetryRum): ActivityLifecycleCallbacks {
Copy link
Contributor Author

@LikeTheSalad LikeTheSalad Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was moved from here.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Thanks!

@LikeTheSalad LikeTheSalad merged commit e22ce45 into open-telemetry:main Jul 11, 2024
3 checks passed
@LikeTheSalad LikeTheSalad deleted the instrumentation-api-p7 branch July 11, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants